Support For Private Repos?

[FlorianWendelborn]

Would be awesome to have that, since most of the code I currently write is private. 😢

[mdxprograms]

I second that. Would like to see that as well.

[ryaninvents]

Planning on giving this package some (sorely-needed) love over the holidays; thank you both for the heads-up!

[mdxprograms]

Sounds great. Don't work too much over the holidays 😁

[ryaninvents]

@mdxprograms looks like I took your advice too literally; good news though, v0.8.0 is out and you should be able to use it with private repos once you get your key set up. Let me know if you have any issues with it.

[FlorianWendelborn]

@r24y How do I activate the private repo support? Preference panel only shows the README for me. Also the issues panel doesn't even open for my repo.

[ryaninvents]

Would you mind pasting here the version of Atom and the version of github-issues you've got installed? You should see a "User Token" field in the preferences pane, and the "GitHub Issues: Open" command should work for public repos without configuration. I'll reopen this issue while this remains unsolved.

[FlorianWendelborn]

https://i.imgur.com/0f70DRI.png

[pjatx]

I have my key setup and it's still not pulling in any issues.

Atom v1.16.0
Github-Issues 0.8.3

[FlorianWendelborn]

Since Atom 0.18 added GitHub integration, I revisited this package. I still have 0.8.3 installed, but now I can see the token field.

I created a token with "full private repo" access, but as far as I could tell from the network inspector this package hasn't requested the GitHub API. It just loads forever, without logging any sort of error in the console.

[ryaninvents]

@dodekeract the package uses the request-promise package to perform network requests, and Atom's devtools only show requests made from WebKit, so they wouldn't show up anyways.

Do you have more than one repository open in Atom? I just realized that it only displays issues for one repo at a time, and if the first repo is not a Github repo then it will not attempt to load them.

[FlorianWendelborn]

@r24y No, I assumed this might be an issue and closed all other projects. I also updated to quick-issues, but that doesn't fix anything. :/

[ryaninvents]

Hm, this is turning into a very interesting issue 🙃

Is there anything else that might be "special" about the setup? Maybe:

• Proxy/firewall? (I'm behind a proxy myself and it's working, but perhaps there's an edge case I'm not experiencing.)
• Permissions granted to the API key are not broad enough? (If the key did not have permission to read issues it might look like this.)
• Issues filter "Open/Closed/All" is not set correctly (e.g. filter set to "Open" but all issues are closed)? (I don't think this is the problem, but someone else just filed a bug that looked like this.)

Any further information you can provide would be helpful, since right now there aren't enough clues as to what's happening (er, I suppose, not happening).