-
-
Notifications
You must be signed in to change notification settings - Fork 0
Emissive textures #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
…into emissive-textures Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds emissive texture support for various ore blocks in the Fluoroscopy resource pack by introducing PBR (Physically Based Rendering) metadata through texture set definitions. The manifest is also updated to support subpacks and lower the minimum engine version requirement for broader compatibility.
Changes:
- Added texture_set.json files for 21 ore types (standard and deepslate variants) with MER (Metalness, Emissive, Roughness) texture references
- Updated manifest.json to declare two subpacks ("Outline Ores" and "Outline & Glow Ores") and lowered min_engine_version from [1, 21, 130] to [1, 21, 110]
- Added corresponding _mer.png texture files for all ore types to enable emissive lighting effects
Reviewed changes
Copilot reviewed 22 out of 44 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| resource_packs/fluoroscopy/manifest.json | Added subpack declarations and lowered min_engine_version |
| resource_packs/fluoroscopy/textures/blocks/*.texture_set.json | Added PBR texture set definitions for overworld ores (coal, copper, diamond, emerald, gold, iron, lapis, redstone, quartz) and nether blocks (nether_gold_ore, gilded_blackstone, ancient_debris) |
| resource_packs/fluoroscopy/textures/blocks/deepslate/*.texture_set.json | Added PBR texture set definitions for all deepslate ore variants |
| resource_packs/fluoroscopy/textures/blocks/*_mer.png | Added MER texture files containing metalness, emissive, and roughness data for PBR rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request adds support for subpacks and introduces texture set definitions for various ore and block textures in the
fluoroscopyresource pack. The manifest is updated to support subpacks and a wider range of engine versions, while new.texture_set.jsonfiles provide PBR (Physically Based Rendering) metadata for multiple ores and blocks.https://learn.microsoft.com/en-us/minecraft/creator/documents/vibrantvisuals/pbroverview?view=minecraft-bedrock-stable#emissive-map
Manifest and Pack Structure Updates:
manifest.json, allowing users to select different visual styles.min_engine_versionrequirement in themanifest.jsonfrom[1, 21, 130]to[1, 21, 110]for broader compatibility.New Texture Set Definitions:
.texture_set.jsonfiles for the following blocks, each specifying PBR metadata:coal_ore,copper_ore,diamond_ore,emerald_ore,gold_ore,iron_ore,lapis_ore,gilded_blackstone,nether_gold_ore,ancient_debris_side,ancient_debris_top. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]deepslate_coal_ore,deepslate_copper_ore,deepslate_diamond_ore,deepslate_emerald_ore,deepslate_gold_ore,deepslate_iron_ore,deepslate_lapis_ore,deepslate_redstone_ore. [1] [2] [3] [4] [5] [6] [7] [8]