Sub packs #7
Merged
Sub packs #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the fluoroscopy resource pack by upgrading to manifest format version 3 and implementing a subpack system that allows users to choose between different visual effects for ore highlighting. The changes enable users to select from outline-only, outline with glow, or outline with glow and x-ray vision modes.
Changes:
- Updated manifest from format version 2 to 3 with string-based version numbers
- Added three subpack configurations (outline, xray, glow) with descriptive settings
- Removed GitHub source URL from pack description in favor of settings section display
Reviewed changes
Copilot reviewed 24 out of 87 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| manifest.json | Updated to format version 3, added subpacks and settings sections, converted version fields to strings |
| texts/en_US.lang | Simplified pack description by removing GitHub URL reference |
| subpacks/xray/* | Added complete xray subpack with MER textures, texture sets, and blocks.json for invisible blocks |
| subpacks/glow/* | Added complete glow subpack with MER textures and texture sets for emissive ore effects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
manifest.jsonfor thefluoroscopyresource pack to support newer engine features and provide more user customization. The main changes include updating the manifest format, switching version numbers to string format, and adding support for subpacks and settings to improve user experience.Manifest and versioning updates:
format_versionfrom 2 to 3 to support new manifest features.versionandmin_engine_versionfields from arrays to strings for both the header and modules sections.Subpack and settings support:
subpackssection with three options (outline,xray,glow) to allow users to choose different visual effects.settingssection with descriptive labels to explain each subpack and provide additional information to users.