Merged
Conversation
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds an attribution and license enforcement script to ensure proper crediting when using the Purse project. The script displays a version and author message in production environments and provides clear licensing terms for users.
- Added
Attribution.client.luauwith Apache 2.0 license notice and attribution requirements - Implemented conditional printing to display version and author information outside of Studio
- Provided three attribution compliance options for users of the library
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| local RunService = game:GetService("RunService") | ||
|
|
||
| if not RunService:IsStudio() then | ||
| print("👛 Running Purse v1.1.0 by @WinnersTakesAll") |
There was a problem hiding this comment.
The version number "v1.1.0" appears to be inconsistent with the version specified in wally.toml, which is currently "1.0.1". Consider using a consistent version number or implement a mechanism to automatically sync the version across files to avoid maintenance issues.
Suggested change
| print("👛 Running Purse v1.1.0 by @WinnersTakesAll") | |
| print("👛 Running Purse v1.0.1 by @WinnersTakesAll") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an attribution and license notice script for the Purse project. The script ensures that users are informed about the licensing requirements and proper crediting for using Purse.
License and attribution enforcement:
Attribution.client.luau, which displays a license notice for Purse and outlines the requirements for attribution or credit when using the project. The script prints a version and author message when not running in Studio mode.