Skip to content

Wally package types#11

Merged
ryanlua merged 6 commits intomainfrom
wally-package-types
Dec 6, 2025
Merged

Wally package types#11
ryanlua merged 6 commits intomainfrom
wally-package-types

Conversation

@ryanlua
Copy link
Owner

@ryanlua ryanlua commented Dec 6, 2025

This pull request primarily improves the developer workflow by automating the generation of Wally package type definitions and updating linting directives. The most significant changes are the addition of the wally-package-types tool to both the development container and CI pipeline, and the consolidation of selene linting directives.

Developer workflow automation:

  • Added wally-package-types as a dependency in rokit.toml to ensure type definitions for Wally packages can be generated.
  • Updated the postCreateCommand in .devcontainer/devcontainer.json to generate a Rojo sourcemap and run wally-package-types after installing dependencies, streamlining local development setup.
  • Modified the release workflow in .github/workflows/release.yml to generate a Rojo sourcemap and Wally package types as part of the CI process, improving type safety and automation in builds.

Linting and code style:

  • Consolidated selene linting directives in src/init.luau by using a single directive line and switching to --!nolint DeprecatedApi for improved clarity and maintainability.

Minor cleanup:

  • Removed unnecessary blank lines after the --!strict directive in src/ContextAction.client.luau and src/TopbarIcon.client.luau. [1] [2]

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@ryanlua ryanlua self-assigned this Dec 6, 2025
Copilot AI review requested due to automatic review settings December 6, 2025 08:59
@ryanlua ryanlua added the bug Something isn't working label Dec 6, 2025
@ryanlua ryanlua added this to the v1.1.0 milestone Dec 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR automates Wally package type generation and consolidates linting directives to improve developer workflow and code maintainability. The key changes include adding wally-package-types tooling to the development and CI pipeline, consolidating selene linting directives in the main module, and removing extra blank lines from client scripts.

Key Changes:

  • Integrated wally-package-types tool into rokit dependencies, devcontainer setup, and CI release workflow for automated type definition generation
  • Consolidated multiple selene linting directives into a single line in src/init.luau and added Luau-specific --!nolint DeprecatedApi directive
  • Removed extraneous blank lines after directives in client scripts

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rokit.toml Added wally-package-types@1.6.2 as a tool dependency
.devcontainer/devcontainer.json Extended postCreateCommand to generate Rojo sourcemap and run wally-package-types after dependency installation
.github/workflows/release.yml Updated Setup Wally step to generate sourcemap and type definitions during CI build process
src/init.luau Consolidated four separate selene directives into one line and added Luau nolint directive for deprecated APIs
src/TopbarIcon.client.luau Removed blank line after strict directive
src/ContextAction.client.luau Removed blank line after strict directive

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanlua ryanlua merged commit 75c82b9 into main Dec 6, 2025
10 checks passed
@ryanlua ryanlua deleted the wally-package-types branch December 6, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant