Merged
Conversation
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR automates Wally package type generation and consolidates linting directives to improve developer workflow and code maintainability. The key changes include adding wally-package-types tooling to the development and CI pipeline, consolidating selene linting directives in the main module, and removing extra blank lines from client scripts.
Key Changes:
- Integrated
wally-package-typestool into rokit dependencies, devcontainer setup, and CI release workflow for automated type definition generation - Consolidated multiple selene linting directives into a single line in
src/init.luauand added Luau-specific--!nolint DeprecatedApidirective - Removed extraneous blank lines after directives in client scripts
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
rokit.toml |
Added wally-package-types@1.6.2 as a tool dependency |
.devcontainer/devcontainer.json |
Extended postCreateCommand to generate Rojo sourcemap and run wally-package-types after dependency installation |
.github/workflows/release.yml |
Updated Setup Wally step to generate sourcemap and type definitions during CI build process |
src/init.luau |
Consolidated four separate selene directives into one line and added Luau nolint directive for deprecated APIs |
src/TopbarIcon.client.luau |
Removed blank line after strict directive |
src/ContextAction.client.luau |
Removed blank line after strict directive |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily improves the developer workflow by automating the generation of Wally package type definitions and updating linting directives. The most significant changes are the addition of the
wally-package-typestool to both the development container and CI pipeline, and the consolidation of selene linting directives.Developer workflow automation:
wally-package-typesas a dependency inrokit.tomlto ensure type definitions for Wally packages can be generated.postCreateCommandin.devcontainer/devcontainer.jsonto generate a Rojo sourcemap and runwally-package-typesafter installing dependencies, streamlining local development setup..github/workflows/release.ymlto generate a Rojo sourcemap and Wally package types as part of the CI process, improving type safety and automation in builds.Linting and code style:
src/init.luauby using a single directive line and switching to--!nolint DeprecatedApifor improved clarity and maintainability.Minor cleanup:
--!strictdirective insrc/ContextAction.client.luauandsrc/TopbarIcon.client.luau. [1] [2]