Fix context action bindings #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes gamepad-related action naming by replacing the "RBX" prefix with "Backpack" across all context action bindings and selection parents in the backpack/inventory UI code. This improves code clarity and consistency.
Key Changes:
- Updated four gamepad action names:
RBXHotbarEquip→BackpackHotbarEquip,RBXBackpackHasGamepadFocus→BackpackHasGamepadFocus,RBXCloseInventory→BackpackCloseInventory,RBXRemoveSlot→BackpackRemoveSlot - Updated selection parent name:
RBXBackpackSelection→BackpackSelection - Added deviation comments to document the naming changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the naming of gamepad-related actions and selection parents in the backpack/inventory UI code by replacing the "RBX" prefix with "Backpack". This change improves clarity and consistency across the codebase. The most important changes are grouped below:
Gamepad Action Name Updates:
ContextActionService:BindActionandContextActionService:UnbindActioncalls to use action names with the "Backpack" prefix instead of "RBX" (e.g.,"RBXHotbarEquip"→"BackpackHotbarEquip","RBXBackpackHasGamepadFocus"→"BackpackHasGamepadFocus","RBXCloseInventory"→"BackpackCloseInventory","RBXRemoveSlot"→"BackpackRemoveSlot"). [1] [2] [3] [4] [5] [6]Selection Parent Name Update:
GuiService:AddSelectionParentfrom"RBXBackpackSelection"to"BackpackSelection".