Open
Conversation
✅ Deploy Preview for wtoeat ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements for Docker deployment, enhances error handling for fetching recipe data, and updates the user interface to provide better feedback during data loading or errors. The most important changes are grouped below.
Dockerization & Deployment:
.github/workflows/publish-ghcr.yml) to automatically build and publish Docker images to GitHub Container Registry (GHCR) on push tomainor tags, enabling easier deployment and distribution.docker-compose.ymlfile for simplified local Docker deployment, allowing configuration of environment variables and exposing the application on port 3000.Dockerfileto set production environment variables, expose port 3000, and add an OpenContainers label for source reference.Documentation:
README.mdwith detailed instructions for Docker deployment (both local build and pulling from GHCR), including example commands and explanations.Recipe Data Fetching & Error Handling:
server/routes/api/recipes.tsto always fetch the public menu from a fixed URL, implementing retry logic and error handling with logging and timeouts to improve reliability.app/components/Eat.vueto include retries, timeout, and to expose loading/error states to the UI.app/components/Eat.vueto display loading, error, and empty data states with appropriate messages and a reload button, improving user experience during data fetch issues.Other:
README.mdto reflect the new location of the recipe API route.