Open
Conversation
oda
reviewed
Jun 9, 2025
| if (nums.length == 0) { | ||
| return 0; | ||
| } | ||
| int[][] currentMaxSum = new int[nums.length][2]; |
fuga-98
reviewed
Jun 9, 2025
| int[] memo = new int[nums.length]; | ||
| Arrays.fill(memo, -1); | ||
| memo[0] = nums[0]; | ||
| robHelper(nums, memo, nums.length - 1); |
There was a problem hiding this comment.
ヘルパー関数には返り値があるのにそれを受け取っていない点がひっかかりました。
副作用を利用して動くのであれば、それが分かるような変数名やコメントを書いてほしいと感じました。
副作用に関して
olsen-blue/Arai60#29 (comment)
nodchip
reviewed
Jun 10, 2025
| public int rob(int[] nums) { | ||
| if (nums.length == 0) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
単独の if 文と if-else if が混ざっているのがやや違和感がありました。いずれも比較される対象が nums.length のため、統一した書き方で書いたほうが、読んでいて混乱が少なくなると思いました。 else if で十分だと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題URL: https://leetcode.com/problems/house-robber/description/