Skip to content

(Fix) - No eth field for payable functions on tx builder#79

Merged
Agupane merged 7 commits intodevelopmentfrom
fix/no-eth-field-tx-builder
Nov 26, 2020
Merged

(Fix) - No eth field for payable functions on tx builder#79
Agupane merged 7 commits intodevelopmentfrom
fix/no-eth-field-tx-builder

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 20, 2020

Closes #75 and #74 by:

  • Excluding from the abi the methods that aren't of type function

Also fixes #1605 by:

  • Checking that the method is payable or not in order to enable the ETH input

@Agupane Agupane self-assigned this Nov 20, 2020
@Agupane Agupane requested a review from rmeissner November 24, 2020 17:42
@Agupane Agupane merged commit f009780 into development Nov 26, 2020
@Agupane Agupane deleted the fix/no-eth-field-tx-builder branch November 26, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction builder: the app is crashed on the "empty" line in the functions list Transaction builder: no ETH field for payable functions

4 participants