Add support for Python 3.13 in conda #39189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit c9e4863; changes) is ready! 🎉 |
tobiasdiez
force-pushed
the
conda-python-13
branch
from
3fd6590 to
0bb2a1b
Compare
```
In file included from build/cythonized/sage/graphs/base/boost_graph.cpp:1278:
build/cythonized/sage/graphs/base/boost_interface.cpp:119:34: error: non-constant-expression cannot be narrowed from type 'value_type' (aka 'unsigned long') to 'int' in initializer list [-Wc++11-narrowing-const-reference]
119 | to_return.push_back({index[boost::source(*ei, graph)],
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build/cythonized/sage/graphs/base/boost_graph.cpp:17503:29: note: in instantiation of member function 'BoostGraph<boost::vecS, boost::vecS, boost::directedS, boost::vecS, boost::property<boost::edge_weight_t, double>>::edge_list' requested here
17503 | __pyx_v_edges = __pyx_v_g.edge_list();
^
```
https://clang.llvm.org/docs/DiagnosticsReference.html#wc-11-narrowing-const-reference
To silence the error assign to a v_index outside of the
initializer list.
Contributor
Author
Comes from the update to gcc14. Fixed in linbox-team/givaro#226, which is in givaro 4.2.1 - already on Conda but until conda-forge/fflas-ffpack-feedstock#21 is fixed it pulls in older givaro. |
Contributor
Author
|
Tests are mostly green (modulo the what appears to be the common background noise of randomly failing tests), so this is now finally ready for review. |
Contributor
|
@tobiasdiez can you please update the checklist for this PR? Thanks! |
Contributor
Author
You mean the one in the PR description? It's mostly there as a reminder for the person opening the PR - but well, I clicked a few checkboxes ;-) |
Contributor
I thought that was used by folks to review/merge PRs :D |
Contributor
Author
|
The two failing tests are due to the flaky |
dimpase
approved these changes
Oct 6, 2025
Member
|
ok, these are conda-only changes |
Contributor
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 11, 2025
sagemathgh-39189: Add support for Python 3.13 in conda <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#39163 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#38749 - sagemath#39249 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39189 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 12, 2025
sagemathgh-39189: Add support for Python 3.13 in conda <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#39163 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#38749 - sagemath#39249 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39189 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
Contributor
|
You can delete the enviorment-3.10-win.yml. We no longer use it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39163
📝 Checklist
⌛ Dependencies