HTTP2 support

[williamstein]

Everybody seems to want this, but nothing does it? It's the first request somebody made when I mentioned this library.

Links:

• Socket leak  jupyterhub/configurable-http-proxy#434 (comment)
• Triage from upstream issues and PRs unjs/httpxy#2 (comment)
• HTTP2 support  http-party/node-http-proxy#1237

[runspired]

surprising nothing does this, http2 support has been around in node (and bun) since forever. Any particular blockers you're aware of?

[williamstein]

There are no blockers I know of. I hope you give it a shot!

[ruimarques-lseg]

Well this has been an interesting saga 😅

I have been migrating my production app tooling, because I really needed http2 for local dev, just to arrive at this issue and realise the ecosystem does not really support it without work-arounds:

• updated from an old craco (react-scripts) to vite 6 (I naively thought vite would just support http2 and didn't even check)
• realised vite had an issue supporting http2 when using proxy
• saw some good soul replaced node-http-proxy vite's dependency with http-proxy-3 to address some of its issues
• realised http-proxy-3 still does not support http2 😛

[mheiduk]

Would be nice if http2 support could be implemented. We've been using a custom plugin with http2-proxy for that reason, but would like to get rid of it.

[williamstein]

Incoming http2 is now supported, with #33 .

[victordidenko]

Looks like xfwd doesn't pass "x-forwarded-host" header with http2

[victordidenko]

Ah, this is due to absence of "host" header in http2 protocol ._.
But my upstream server is http1 and requires this header.
I fixed it like this:

configure: (proxy) => {
  proxy.on('proxyReq', (proxyReq, req) => {
    const authority = req.headers[':authority']
    if (authority) {
      proxyReq.setHeader('X-Forwarded-Host', authority)
    }
  })
},

not sure if it should be by default or not

[williamstein]

solved via #34

[Corvince]

@victordidenko Thanks for the heads-up! Glad you got it working, but you are right it should be based on the authority pseudo-header. I added this in #42