Feature/docker services run nonroot#117
Merged
ville-friman-siili merged 8 commits intodevelopfrom Oct 16, 2020
Merged
Conversation
Renaming is part of commits making the dockerized services run as a non-root user.
New nginx.conf contains configurations for the server instance. This commit is a part of series of commits to make the dockerized services run as a non-root.
This commit is a part of series of commits to make the dockerized services run as a non-root user.
This commit is a part of series of commits to make the dockerized services run as a non-root user.
…ver url Nginx port and backend server url can be overridden whit build args when building the Docker image. Arguments are nginx_port (default value 8080) and backend_url (default http://backend-server:5000).
For some reason container failed to start in OpenShift when log directory was under /tmp due permission reasons so this moves them back to the orginal directory.
…file Adds new section about the configurable Docker build arguments inside the Dockerfile-prod.
ville-friman-siili
force-pushed
the
feature/docker_services_run_nonroot
branch
from
078bd30 to
057acd1
Compare
vade5g
reviewed
Oct 14, 2020
backend_server/Dockerfile
Outdated
| CMD python server.py --database $DATABASE --host $HOST --user $USER --pw $PASSWORD --port $PORT | ||
|
|
||
| EXPOSE 5000 No newline at end of file | ||
| EXPOSE 5000 |
Contributor
There was a problem hiding this comment.
If the backend_url is configured with an env variable, should we also have a variable here to change the exposed port, if someone wants to expose something other than 5000? @ville-friman-siili
Contributor
Author
There was a problem hiding this comment.
Excellent point. I was so focused on the frontend part that forgot this. I'll change this before merging.
vade5g
previously approved these changes
Oct 14, 2020
Backend server's docker file was configured to expose always the port 5000, which might not match with the $PORT argument given to server.
lakooi
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTICE I'll merge this branch myself into the development branch. This branch changes the port which the Ngnix listens so it requires changes elsewhere.