Merged
Conversation
vade5g
reviewed
Oct 20, 2020
|
|
||
| FOR ${header} IN @{series_names} | ||
| Click Element //h3[.="${header}"]/ancestor-or-self::div[2]/div[2]/div[1] | ||
| Click Element //h4[.="${header}"]/ancestor-or-self::section[2]/div[2]/div[1] |
Contributor
There was a problem hiding this comment.
Ehmm, this selector is not a good idea, we could have a chat about these together.
Contributor
There was a problem hiding this comment.
I will change these to function like so
-> The cards will have dynamic ids for different parts based on the unique series name, such as ci_frontend_latest
-> We can then use unique series name as a locator with a the id
Currently What the locator does is it finds the correct header element based on content and then moves one container up from the element after which the element is then found.
vade5g
reviewed
Oct 20, 2020
| Wait Until Element is Enabled ${series_list} | ||
| FOR ${header} IN @{series_names} | ||
| Click Element //h3[.="${header}"]/ancestor-or-self::div[2]/div[2]/div[2] | ||
| Click Element //h4[.="${header}"]/ancestor-or-self::section[2]/div[2]/div[2] |
vade5g
reviewed
Oct 20, 2020
|
|
||
| FOR ${header} IN @{series_names} | ||
| Click Element //h3[.="${header}"]/ancestor-or-self::div[2]/div[2]/div[1] | ||
| Click Element //h4[.="${header}"]/ancestor-or-self::section[1]/div[1]/div[1] |
Contributor
There was a problem hiding this comment.
We can surely get a better locator for this element. Let's discuss this together.
lakooi
approved these changes
Oct 20, 2020
vade5g
reviewed
Oct 20, 2020
| #This long identifier points to the header part of the component that matches the header text | ||
| FOR ${header} IN @{team_names} | ||
| Click Element //*[@id="team"]/div/div[*]/h3[contains(text(),"${header}")] | ||
| Click Element //*[@id="team"]/div/section[*]/h4[contains(text(),"${header}")] |
vade5g
reviewed
Oct 20, 2020
vade5g
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.