Update pillar.example to good-citizen defaults#63
Update pillar.example to good-citizen defaults#63jinnatar wants to merge 2 commits intosaltstack-formulas:masterfrom jinnatar:patch-1
Conversation
|
@Artanicus , changing these values in Adding these values to Mind you add these values in |
aanriot
left a comment
aanriot
left a comment
There was a problem hiding this comment.
I agree with @javierbertoli . Thanks for you work @Artanicus .
alxwr
left a comment
alxwr
left a comment
There was a problem hiding this comment.
I agree with @javierbertoli . Thanks for you work @Artanicus .
|
Best reviewed: commit by commit
Optimal code review plan
|
Specifying `renew-by-default` in the config, regardless of True / False enables the flag. This causes certbot to force-renew on every timer run and means you will hit the rate-limit fairly quickly. A safer default is `keep-until-expiring` where the renew will only be done when it's actually advisable. `expand` allows an expanded domain list to renew correctly without forking a new domainset. This is something that most users will want.
Also specify `config` as a hash to make it easier to provide/compose the config from multiple pillar files. Maintain backward compatibility (supplying `config` as a string) so that the formula continues to work as expected if a `config` string is already available. BREAKING CHANGE: `config` can now be provided as a hash or a string; defaults are modified and, while sane and desirable, do change the behavior of the formula.
|
As this PR got stale, I updated and merged it on #73. |
5 participants
Specifying
renew-by-defaultin the config, regardless of True / False enables the flag. This causes certbot to force-renew on every timer run and means you will hit the rate-limit fairly quickly. A safer default iskeep-until-expiringwhere the renew will only be done when it's actually advisable.expandallows an expanded domain list to renew correctly without forking a new domainset. This is something that most users will want.