fix(defaults): install certbot with no plugins#84
Merged
javierbertoli merged 1 commit intosaltstack-formulas:masterfrom Jul 2, 2021
Merged
Conversation
BREAKING CHANGE: The formula was installing the Apache plugin by default which is not reasonable. Also, as `letsencrypt:pkgs` is a list, _adding_ another entry in the list was not replacing this default, causing undesired packages to be installed. The new default is an empty list of packages, defaulting to `certbot` in the code.
javierbertoli
force-pushed
the
dont-force-default-plugin
branch
from
4d26fc0 to
70dafdd
Compare
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?Yes.
The formula was installing the Apache plugin by default
which is not reasonable. Also, as
letsencrypt:pkgsis a list,adding another entry in the list was not replacing this default, causing
undesired packages to be installed.
The new default is an empty list of packages, defaulting to
certbotinthe code.
Related issues and/or pull requests
Describe the changes you're proposing
This PR defaults to just installing
certbotby default, and useletsencrypt:pkgsto specify other packages, as plugins.For most users of the formula, it won't require any change to their pillars, but marking it as a BREAKING CHANGE to play safe.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context