Install certbot through pip#85
Merged
javierbertoli merged 8 commits intosaltstack-formulas:masterfrom Nov 18, 2021
Merged
Conversation
added 2 commits
August 2, 2021 13:39
Change the use_package boolean to install_method string. This will allow different installation methods besides system packages and git in the future.
Offer alternative method of installing certbot with pip. Currently untested on most supported platforms.
XeryusTC
changed the title
added 4 commits
August 3, 2021 12:48
Can now give a list of plugins to install when using the pip installation method.
|
Apologies for the delay, @XeryusTC. I'm going to ask @javierbertoli to have a look at this, since there may be a breaking change in this. The good thing is that all the CI instances are passing, including the new suite that you have provided. |
myii
reviewed
Sep 14, 2021
litnialex
pushed a commit
to litnialex/letsencrypt-formula
that referenced
this pull request
Oct 1, 2021
javierbertoli
requested changes
Oct 31, 2021
Member
javierbertoli
left a comment
javierbertoli
left a comment
There was a problem hiding this comment.
@XeryusTC, It LGTM, nice addition.
I see there are a few conflicts now.
If you fix them, I think it's OK to merge.
javierbertoli
approved these changes
Nov 18, 2021
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No. Although configuration has changed backwards compatibility has been preserved by adding some logic in
letsencrypt/map.jinja.Related issues and/or pull requests
Describe the changes you're proposing
Install certbot by using pip. This is similar to using git except that it will download and install through pip. A virtualenv is created (default:
/opt/letsencrypt).Pillar / config required to test the proposed changes
The
use_packagepillar variable is replaced byinstall_method. So for the system package installation methodbecomes
Likewise for the git installation method. Additionally one can now do
To use the new pip installation method.
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context