ci(windows): test using GitHub Actions by myii · Pull Request #70 · saltstack-formulas/packages-formula

myii · 2020-08-08T20:24:06Z

PR progress checklist (to be filled in by reviewers)

Changes to documentation are appropriate (or tick if not required)
Changes to tests are appropriate (or tick if not required)
Reviews completed

What type of PR is this?

Primary type

[build] Changes related to the build system
[chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ci] Changes to the continuous integration configuration
[feat] A new feature
[fix] A bug fix
[perf] A code change that improves performance
[refactor] A code change that neither fixes a bug nor adds a feature
[revert] A change used to revert a previous commit
[style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[docs] Documentation changes
[test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Built upon the work done by @dafyddj in other formulas:

Brings in automated testing for Chocolatey as discussed in #60 (CC: @kartnico).

Describe the changes you're proposing

Add Windows testing for Chocolatey installations.

Pillar / config required to test the proposed changes

As provided.

Debug log showing how the proposed changes work

As seen in the GitHub Actions logs.

Documentation checklist

Updated the README (e.g. Available states).
Updated pillar.example.

Testing checklist

Included in Kitchen (i.e. under state_top).
Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
Updated the relevant test pillar.

Additional context

@dafyddj As mentioned in Slack, I haven't managed to get the Vagrant testing working yet so I'd appreciate it if you have any suggestions for that.

Using this PR as a precursor to providing Windows testing configuration via. the ssf-formula.

pull-assistant · 2020-08-08T20:24:09Z

Best reviewed: commit by commit

Optimal code review plan

ci(windows): test using GitHub Actions

Powered by Pull Assistant. Last update 1040cc8 ... 1040cc8. Read the comment docs.

myii · 2020-08-11T17:25:16Z

After feedback in the Formulas' working group meeting, tested some modifications in another branch and getting much better performance now:

https://github.com/myii/packages-formula/runs/972293120?check_suite_focus=true
- Avoided the Chocolatey installation via. packages.chocolatey.required.pkgs -- also allowed an empty init_environment in kitchen.github.yml.
- Avoided installing adobereader (i.e. large package).

@dafyddj mentioned that he would be able to add Chocolatey to the pre-salted image used by kitchen.vagrant.yml, so this PR will be checked again locally once that's done.

Also need to add the relevant documentation to README.rst.

As for the debian-10 failure, that's unrelated to this PR. Appears to be an issue with that particular snap but would need to dig down further, if I can make time. Otherwise, may have to just disable it in the test pillar.

dafyddj · 2020-08-14T11:48:43Z

@myii uploaded a new Vagrant box version. Do you want to try v2020.8.198?

myii · 2020-08-25T20:47:39Z

@myii uploaded a new Vagrant box version. Do you want to try v2020.8.198?

Just confirming here that the new box works -- thanks. I've updated the PR accordingly, including removing unnecessary installations to make the Windows testing faster. So this PR should be ready for merging. The debian-10 failure is unrelated.

CC: @dafyddj @javierbertoli.

dafyddj · 2020-08-28T10:22:50Z

kitchen.github.yml

+provisioner:
+  salt_install: bootstrap
+  salt_bootstrap_options: -pythonVersion 3
+  init_environment: ""


Suggested change

init_environment: ""

Would suggest just removing the unneeded lines.

dafyddj · 2020-08-28T10:24:02Z

kitchen.vagrant.yml

+    provisioner:
+      init_environment: ""


Suggested change

provisioner:

init_environment: ""

dafyddj · 2020-08-28T10:59:24Z

Would also suggest changing the platform name to just windows for consistency.

* Semi-automated using myii/ssf-formula#304

myii · 2021-03-26T11:27:57Z

Updated and finalised using myii/ssf-formula#304.

``` Offenses: test/integration/default/controls/pkgs_spec.rb:27:5: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use iotop: instead. 'iotop': '' ^^^^^^^ test/integration/default/controls/pkgs_spec.rb:33:5: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use alien: instead. 'alien': '8.95-8.fc29', ^^^^^^^ test/integration/default/controls/pkgs_spec.rb:34:5: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use iotop: instead. 'iotop': '0.6-18.fc29' ^^^^^^^ test/integration/default/controls/pkgs_spec.rb:46:5: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use alien: instead. 'alien': '8.95', ^^^^^^^ test/integration/default/controls/pkgs_spec.rb:48:5: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use iotop: instead. 'iotop': '0.6-' ^^^^^^^ ```

myii · 2021-03-26T16:32:43Z

Thanks for the review, @dafyddj.

saltstack-formulas-travis · 2021-03-26T16:59:52Z

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

myii requested review from a team and javierbertoli as code owners August 8, 2020 20:24

myii requested a review from dafyddj August 8, 2020 20:24

myii force-pushed the ci/add-windows-testing-via-github-actions branch from 185d734 to 992eb48 Compare August 8, 2020 21:27

myii force-pushed the ci/add-windows-testing-via-github-actions branch from 992eb48 to 1040cc8 Compare August 25, 2020 20:45

myii mentioned this pull request Aug 25, 2020

[BUG] version_repo override ignored on windows? saltstack-formulas/zabbix-formula#144

Open

dafyddj reviewed Aug 28, 2020

View reviewed changes

myii mentioned this pull request Dec 19, 2020

fix(compose-ng): Adding ability to set devices saltstack-formulas/docker-formula#269

Merged

19 tasks

myii force-pushed the ci/add-windows-testing-via-github-actions branch from 1040cc8 to ccd065b Compare March 26, 2021 11:21

myii added 2 commits March 26, 2021 11:27

ci: enable Vagrant-based testing using GitHub Actions

49fc85d

* Semi-automated using myii/ssf-formula#304

ci(windows): test using GitHub Actions

e7bbefa

myii force-pushed the ci/add-windows-testing-via-github-actions branch from ccd065b to c6e1380 Compare March 26, 2021 12:11

myii force-pushed the ci/add-windows-testing-via-github-actions branch from c6e1380 to f7a6fcf Compare March 26, 2021 12:18

myii mentioned this pull request Mar 26, 2021

feat(vagrant+proxy): add testing via. GitHub Actions myii/ssf-formula#304

Merged

myii force-pushed the ci/add-windows-testing-via-github-actions branch from a443b4e to bf0e39c Compare March 26, 2021 14:36

docs(readme): add Testing with Vagrant section

d734d43

myii force-pushed the ci/add-windows-testing-via-github-actions branch from bf0e39c to d734d43 Compare March 26, 2021 14:58

myii merged commit fb72e66 into saltstack-formulas:master Mar 26, 2021

myii deleted the ci/add-windows-testing-via-github-actions branch March 26, 2021 16:30

saltstack-formulas-travis added the released label Mar 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(windows): test using GitHub Actions#70

ci(windows): test using GitHub Actions#70
myii merged 4 commits intosaltstack-formulas:masterfrom
myii:ci/add-windows-testing-via-github-actions

myii commented Aug 8, 2020 •

edited

Loading

Uh oh!

pull-assistant bot commented Aug 8, 2020 •

edited

Loading

Uh oh!

myii commented Aug 11, 2020 •

edited

Loading

Uh oh!

dafyddj commented Aug 14, 2020

Uh oh!

myii commented Aug 25, 2020 •

edited

Loading

Uh oh!

dafyddj Aug 28, 2020

Uh oh!

dafyddj Aug 28, 2020

Uh oh!

dafyddj Aug 28, 2020

Uh oh!

dafyddj Aug 28, 2020

Uh oh!

dafyddj commented Aug 28, 2020

Uh oh!

myii commented Mar 26, 2021

Uh oh!

myii commented Mar 26, 2021

Uh oh!

saltstack-formulas-travis commented Mar 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

myii commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR progress checklist (to be filled in by reviewers)

What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

Uh oh!

pull-assistant bot commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myii commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dafyddj commented Aug 14, 2020

Uh oh!

myii commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dafyddj Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

dafyddj Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

dafyddj Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

dafyddj Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

dafyddj commented Aug 28, 2020

Uh oh!

myii commented Mar 26, 2021

Uh oh!

myii commented Mar 26, 2021

Uh oh!

saltstack-formulas-travis commented Mar 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

myii commented Aug 8, 2020 •

edited

Loading

Does this PR introduce a `BREAKING CHANGE`?

pull-assistant bot commented Aug 8, 2020 •

edited

Loading

myii commented Aug 11, 2020 •

edited

Loading

myii commented Aug 25, 2020 •

edited

Loading