refactor: Use relative state include#74
Merged
javierbertoli merged 1 commit intosaltstack-formulas:masterfrom Jun 14, 2021
Merged
Conversation
My use case is that I actually have to rename this formula because the
SUSE Manager ships with its own `packages` formula that it uses
internally. But I still want to use this formula in combination. So one
of them has to be renamed. This change makes that way easier.
=== Do not change lines below ===
{
"chain": [],
"cmd": "git ls-files -z packages | xargs --null -I '()' find '()' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#packages/#./#g;s#- packages\\.#- .#;'",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Contributor
|
While discussing this with @javierbertoli, I realised that we had considered relative imports before:
However, we had to wait until all supported versions of Salt had it available:
Since we're well clear of @saltstack-formulas/wg These relative paths should be something we discuss in the next working group meeting. |
Member
|
@ypid-geberit thanks for this PR! |
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ypid-geberit
added a commit
to ypid-geberit/firewalld-formula
that referenced
this pull request
Oct 5, 2021
ypid-geberit
added a commit
to ypid-geberit/firewalld-formula
that referenced
this pull request
Oct 5, 2021
Ref: saltstack-formulas/packages-formula#74 === Do not change lines below === { "chain": [], "cmd": "git ls-files -z firewalld | xargs --null -I '()' find '()' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#\"firewalld/#\"./#g;s#- firewalld\\.#- .#;'", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case is that I actually have to rename this formula because the SUSE Manager ships with its own
packagesformula that it uses internally. But I still want to use this formula in combination. So one of them has to be renamed. This change makes that way easier.Applied with
datalad run, see this record:{ "chain": [], "cmd": "git ls-files -z packages | xargs --null -I '()' find '()' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#packages/#./#g;s#- packages\\.#- .#;'", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." }PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Use relative state include.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context