Migrate Travis CI testing setup to GitHub actions #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Github Actions workflow to call tox and run tests. Doesn't currently implement coverage functionality - will add that later.
Adds an exclusion for master and python 3.5/3.6 as 3006 onwards requires py 3.7.
Updates pytest-salt url to point to https://github.com/vmware-archive/pytest-salt. Should re-work tests to use pytest-salt-factories.
Updates requirements to match current salt requirements for zeromq and tornado.
Contributor
nicholasmhughes
left a comment
nicholasmhughes
left a comment
There was a problem hiding this comment.
question (non-blocking): Additional question... Are we planning on using the Azure Pipelines configuration, or will that get ripped out as well?
nicholasmhughes
approved these changes
Jan 20, 2023
This was referenced Apr 18, 2023
This was referenced May 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates tests to Github Actions as per issue #220.
This does the minimum possible to get the tests running as GH Actions workflows against current Salt and Python versions. I've stuck with the existing tox setup and only updated requirements where necessary to get the tests to set up and run.
I haven't setup the codecov functionality but will tackle that at a later stage,
Currently, some tests are failing for almost all the combinations of python/salt/transport. The majority of those are the integration tests, which rely on the archived pytest-salt extension.
Think it would be worth merging this as is and I'll then work on issues with the actual test suite in #225