[modules/postgresql] modules for cluster management in postgresql (debian specific)#21314
[modules/postgresql] modules for cluster management in postgresql (debian specific)#21314thatch45 merged 5 commits intosaltstack:developfrom
Conversation
…bian specific) related to saltstack#21293
salt/modules/deb_postgres.py
Outdated
There was a problem hiding this comment.
the virtualname conflicts with the 'postgres' module, what about postgres_cluster ?
There was a problem hiding this comment.
@kiorky this was deliberate, the command line is then unified for postgres operations. But if this is not common pratice I'm can change that.
There was a problem hiding this comment.
Uhm, i though one of the modules declaring the same virtualname wins the name and then they are not merged together, but i can be wrong here.
Interresting, i'm testing this to verify.
There was a problem hiding this comment.
Indeed, modules are merged, something i did not known about the loader.
So yes, as there are no function no conflict, there is no issue left here.
|
i'm helping @arthurlogilab for the lint stuff to get the tests going further :) |
|
Et voilà ! |
|
@arthurlogilab if #20540 is merged, this will broke the thing with |
[modules/postgresql] modules for cluster management in postgresql (debian specific)
4 participants
related to #21293