Correct a factor of the lunisolar K2 tides#20
Merged
Conversation
hleroy
added a commit
to hleroy/pytides
that referenced
this pull request
Aug 14, 2019
socoyjonathan
added a commit
to socoyjonathan/pytides
that referenced
this pull request
Apr 24, 2022
The change can be verified on page 46 on https://tidesandcurrents.noaa.gov/publications/SpecialPubNo98.pdf Additionally, this PR reflects PR from sam-cox#20
Contributor
|
The 0.2523 is there. |
drf5n
pushed a commit
to drf5n/pytides
that referenced
this pull request
Oct 13, 2022
sam-cox
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this correction after carefully reviewing against ftp://ftp.flaterco.com/xtide/SP98-1958.pdf and http://www.vliz.be/imisdocs/publications/85/242885.pdf; factor can be found on page 46