Monitoring dashboard#60
Monitoring dashboard#60psankhe28 wants to merge 13 commits intosamagra-comms:monitoring-dashboardfrom
Conversation
|
@psankhe28 is attempting to deploy a commit to the UCI Team on Vercel. A member of the Team first needs to authorize it. |
geeky-abhishek
left a comment
geeky-abhishek
left a comment
There was a problem hiding this comment.
Overall I can see a lot of code is repeated multiple times ,try to move them to some util to reduce the line of code and reuse the created logic
| } | ||
| /> | ||
| <Route | ||
| path="/monitoring" |
There was a problem hiding this comment.
can you use some config array and iterate through each element to reduce the line of code
| const res = JSON.parse(response.data.result); | ||
| setBroadcastTransformerData(res["Broadcast Transformer".trim()] || {}); | ||
| } catch (error) { | ||
| console.error("Error toggling:", error); |
There was a problem hiding this comment.
toastify the error instead of console.log
| }; | ||
|
|
||
| useEffect(() => { | ||
| func(); |
There was a problem hiding this comment.
Whenever the value of date changes, the function is being called so it is present in use effect
| setSelectedChart(value); | ||
| setDropdownLabel(label); | ||
| }; | ||
|
|
There was a problem hiding this comment.
this is not good either use some function to get the final value or use memorised value
2 participants
No description provided.