Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

WIP libnetwork - Add support for /networks and /services API endpoints#152

Closed
abronan wants to merge 1 commit intosamalba:masterfrom
abronan:libnetwork_api
Closed

WIP libnetwork - Add support for /networks and /services API endpoints#152
abronan wants to merge 1 commit intosamalba:masterfrom
abronan:libnetwork_api

Conversation

@abronan
Copy link
Collaborator

@abronan abronan commented Aug 21, 2015

Tested with docker experimental.

The API is going to change (with the sandbox entity: see moby/libnetwork#365), but I open the PR to keep track of the evolution on both sides.

TODO items:

  • Add error scheme for all methods
  • Move the networks and services endpoints in their own file (networks.go/services.go?)
  • Include new sandbox entity
  • Refactor and split tests

Signed-off-by: Alexandre Beslic abronan@docker.com

…ested with docker experimental

Signed-off-by: Alexandre Beslic <abronan@docker.com>
@abronan
Copy link
Collaborator Author

abronan commented Aug 21, 2015

Also, it's now probably time to cleanup the client a little bit... And split in multiple files (containers.go/images.go/networks.go/services.go, etc.)

@mavenugo
Copy link

@aboch can you please take a look ?

@abronan
Copy link
Collaborator Author

abronan commented Aug 24, 2015

/cc @aluzzardi @vieux @chanwit @jimmyxian (cc'ing just so you can follow the discussion here ;)

@chanwit
Copy link

chanwit commented Aug 24, 2015

👍

@jimmyxian
Copy link
Contributor

Cool, split in multiple files is pretty good.

@aluzzardi
Copy link
Collaborator

Awesome :)

But ... aren't we going to blindly proxy the calls to the engine anyway ? :)

@jimmyxian
Copy link
Contributor

@aluzzardi
In Swarm, I think proxy the calls to the engine is a good way to keep api fresh.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support only one query parameter for these endpoints in libentworks, either name or partial-id
I think this should be: uri += "?name=" +name and uri += "?partial-id=" + partialId below.

@abronan
Copy link
Collaborator Author

abronan commented Aug 25, 2015

@aluzzardi Most of them yes ;)

@aboch Thanks! Will revisit and fix when your PR will be merged on libnetwork's side.

@abronan
Copy link
Collaborator Author

abronan commented Oct 6, 2015

replaced by #169 that supports the new networking UX

@abronan abronan closed this Oct 6, 2015
@abronan abronan deleted the libnetwork_api branch August 19, 2016 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants