WIP libnetwork - Add support for /networks and /services API endpoints#152
WIP libnetwork - Add support for /networks and /services API endpoints#152abronan wants to merge 1 commit intosamalba:masterfrom
Conversation
…ested with docker experimental Signed-off-by: Alexandre Beslic <abronan@docker.com>
|
Also, it's now probably time to cleanup the client a little bit... And split in multiple files ( |
|
@aboch can you please take a look ? |
|
/cc @aluzzardi @vieux @chanwit @jimmyxian (cc'ing just so you can follow the discussion here ;) |
|
👍 |
|
Cool, split in multiple files is pretty good. |
|
Awesome :) But ... aren't we going to blindly proxy the calls to the engine anyway ? :) |
|
@aluzzardi |
There was a problem hiding this comment.
We support only one query parameter for these endpoints in libentworks, either name or partial-id
I think this should be: uri += "?name=" +name and uri += "?partial-id=" + partialId below.
|
@aluzzardi Most of them yes ;) @aboch Thanks! Will revisit and fix when your PR will be merged on libnetwork's side. |
|
replaced by #169 that supports the new networking UX |
Tested with docker experimental.
The API is going to change (with the
sandboxentity: see moby/libnetwork#365), but I open the PR to keep track of the evolution on both sides.TODO items:
networks.go/services.go?)sandboxentitySigned-off-by: Alexandre Beslic abronan@docker.com