Various lockscreen tweaks/fixes #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I vaguely recall trying to do this in the past and it exploded in really weird and hard to diagnose ways. But now I can't seem to replicate that and all the tests pass, so ... Signed-off-by: Sam Day <me@samcday.com>
Useful (hopefully) comments and less insane handling of USP variable. Also removed the unnecessary weak-allow-none usage and replaced it with owned clones or @watch usage where applicable. Reading this function makes my eyes bleed 85% less. #winning #tigerblood Signed-off-by: Sam Day <me@samcday.com>
The default "Enter Passcode" isn't useful for phrog's use case Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
This way, pressing escape or hitting the Phosh.Lockscreen idle timer doesn't boop the user back to the user session page. Because we manage the default page state from a notify::page handler, we don't need to also set the default page in trivial flow anymore. Signed-off-by: Sam Day <me@samcday.com>
Remove some unnecessary WARN level logs in the cases where we're already clearly communicating something to the user via the UI. Use the unlock status better by improving the language in these messages. Ensure that resetting the greetd session in response to an auth failure is robust. Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
emergency-calls
first-run
keypad-shuffle
simple-flow
trivial-flow
|
Owner
Author
|
Tests all look good, going to yolo this straight into main now so I can dogfood it a bit over the next couple of days before a 0.45 release candidate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up a few parts of the lockscreen code to be more readable and better annotated, since there's a lot of dragons in that area. Fixed the issue with inactivity bouncing a user back to user/session page (so this closes #97), and hopefully made the interactions more robust and more user-friendly overall.