ci: split build-image into separate workflow #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
emergency-calls
first-run
keypad-shuffle
simple-flow
trivial-flow
|
The current setup doesn't work with pull requests, even if no changes were made to the CI Dockerfile. So instead, split the build-image job into a separate workflow that is *only* triggered manually. If someone submits a PR that updates the CI image, a maintainer with admin/write access must cherry-pick those commits into a branch, push that to the origin repo, and run this workflow on that branch. I think there's a better way to do this with pull_request_target, but I need to wrap my brain around the security implications first. Signed-off-by: Sam Day <me@samcday.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup doesn't work with pull requests, even if no changes were made to the CI Dockerfile.
So instead, split the build-image job into a separate workflow that is only triggered manually. If someone submits a PR that updates the CI image, a maintainer with admin/write access must cherry-pick those commits into a branch, push that to the origin repo, and run this workflow on that branch.
I think there's a better way to do this with pull_request_target, but I need to wrap my brain around the security implications first.