Skip to content

Conversation

@werdahias
Copy link

No description provided.

zbus = { version = "5", default-features = false, features = ["blocking", "async-io"] }
nix = { version = "0.29", features = ["signal"] }
async-global-executor = "2.4.1"
async-global-executor = "3.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samcday would it make sense to switch deps 3.0 to give distros some leeway in micro versions? We're doing that in xdg-desktop-portal-phosh and pfs too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this wouldn't be needed 3.0.0 is actually interpreted as >= 3.0.0, < 4

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, I thought 3.0 would give us >= 3.0.x but <= 3.1.0 but it doesn't (https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html)

@a-wai a-wai added the ci-ok PR looks safe / author is trusted, run pull_request_target build workflow label Nov 18, 2025
@github-actions
Copy link

The CI build recorded and generated some videos

Demo video (shown on README and release notes)

accent-colours

emergency-calls

first-run

simple-flow

trivial-flow

@samcday
Copy link
Owner

samcday commented Nov 26, 2025

Apologies for the delay here. Thanks for the contributions ya'll 🙏

@samcday samcday merged commit 0c29f3d into samcday:main Nov 26, 2025
3 checks passed
@samcday
Copy link
Owner

samcday commented Nov 26, 2025

@werdahias / @a-wai / @agx maybe one of ya'll could help teach me the ways of the Debian, here? After merging this PR I decided to try and get phrog building .debs as part of upstream CI (#138).

It seems that the async-global-exec crate is still 2.x even on unstable. So I picked experimental but I'm getting really cursed depsolver issues that make me think phrog should maybe not be playing in that sandpit 😅

So I guess a specific question is: what's the best way to ensure phrog upstream stays in sync with Debian? Feel free to drop any thoughts on that linked PR :)

@agx
Copy link
Collaborator

agx commented Nov 27, 2025

So I guess a specific question is: what's the best way to ensure phrog upstream stays in sync with Debian?

I'm not much of a Rust person so I'll just say what we're doing in other packages:

  • Be conservative with crate dependencies, the fewer the better. If possible don't depend on most recent features. This is done to ease distro maintainers life
  • Don't specify the Rust crates in the dependencies by default as our aim is not to test the build in Debian but provide a package that matches closely what the developer committed.

If one wants to do perform both a crates.io and a build with crates using Debian packages one can use build profiles.

@a-wai
Copy link
Collaborator

a-wai commented Nov 27, 2025

It seems that the async-global-exec crate is still 2.x even on unstable. So I picked experimental [...]

Actually v3 was uploaded to unstable yesterday, and is now available there ;) Regarding your issue, it could be due to a dependency confict, e.g. another crate explicitly depending on async-global-exec v2. The best way to be sure would be to try installing all build-deps manually in a container

So I guess a specific question is: what's the best way to ensure phrog upstream stays in sync with Debian? Feel free to drop any thoughts on that linked PR :)

I'd just stick with unstable for CI, and maybe mark it as "allowed to fail" as there will be issues with broken dependency chain from time to time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-ok PR looks safe / author is trusted, run pull_request_target build workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants