-
Notifications
You must be signed in to change notification settings - Fork 6
Update async-global-executor dependency #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| zbus = { version = "5", default-features = false, features = ["blocking", "async-io"] } | ||
| nix = { version = "0.29", features = ["signal"] } | ||
| async-global-executor = "2.4.1" | ||
| async-global-executor = "3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samcday would it make sense to switch deps 3.0 to give distros some leeway in micro versions? We're doing that in xdg-desktop-portal-phosh and pfs too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this wouldn't be needed 3.0.0 is actually interpreted as >= 3.0.0, < 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I thought 3.0 would give us >= 3.0.x but <= 3.1.0 but it doesn't (https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html)
|
Apologies for the delay here. Thanks for the contributions ya'll 🙏 |
|
@werdahias / @a-wai / @agx maybe one of ya'll could help teach me the ways of the Debian, here? After merging this PR I decided to try and get phrog building It seems that the async-global-exec crate is still 2.x even on unstable. So I picked experimental but I'm getting really cursed depsolver issues that make me think phrog should maybe not be playing in that sandpit 😅 So I guess a specific question is: what's the best way to ensure phrog upstream stays in sync with Debian? Feel free to drop any thoughts on that linked PR :) |
I'm not much of a Rust person so I'll just say what we're doing in other packages:
If one wants to do perform both a crates.io and a build with crates using Debian packages one can use build profiles. |
Actually v3 was uploaded to unstable yesterday, and is now available there ;) Regarding your issue, it could be due to a dependency confict, e.g. another crate explicitly depending on async-global-exec v2. The best way to be sure would be to try installing all build-deps manually in a container
I'd just stick with unstable for CI, and maybe mark it as "allowed to fail" as there will be issues with broken dependency chain from time to time |






No description provided.