systemd-session: Depend on mobi.phosh.OSK.target #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Avoids warnings during build Signed-off-by: Guido Günther <agx@sigxcpu.org>
This keeps OSK startup working with gnome-session >= 49 which removed the `RequiredComponents` key. We can keep that around in our session file for a bit longer so we can work with older gnome-session as well. Signed-off-by: Guido Günther <agx@sigxcpu.org>
Collaborator
Author
|
Turns out we need a bit more to work with gnome-session 49. This fixes it for me. |
This comment has been minimized.
This comment has been minimized.
Since RequiredComponents is no longer handled by gnome-session we need to start phrog via systemd. The unit files match what phosh does. This allows phrog to start with gnome-session >= 49. Signed-off-by: Guido Günther <agx@sigxcpu.org>
Collaborator
Author
|
v1.1
|
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
emergency-calls
first-run
simple-flow
trivial-flow
|
Collaborator
Author
|
As this prevents the session from starting I'll merge this. @samcday please let me know if I should let things sit longer for feedback. |
Owner
No complaints here (especially since I've been quite inactive lately!) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps OSK startup working with gnome-session >= 49 which removed the
RequiredComponentskey. We can keep that around in our session file for a bit longer so we can work with older gnome-session as well.This needs https://gitlab.gnome.org/World/Phosh/stevia/-/merge_requests/242 hence draft