Optimize trivial flow #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the shell was doing it in the a handler, which was technically incorrect since it's possible that the loading of users is slow enough to not be done by the time shell readiness signal fires. The main motivation for doing it, though, is to prepare for the scenario where the shell starts up without being initially locked, which is necessary to support a "first-run" app.
this is set once all known users have loaded from AccountService
Makes it possible to implement a test with only a single user (Phoshi, of course)
The "trivial case" is when there is one user and one session available for selection. In this case, we make the keypad the default page as well as switching to it.
This test will pass in CI but fail on local dev machines with more than one session available, as I haven't properly mocked that out yet.
samcday
force-pushed
the
optimize-trivial-flow
branch
from
49eb669 to
787c13c
Compare
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
keypad-shuffle
simple-flow
trivial-flow
|
|
I can confirm both flows works as expected. Once i delete the extra session files in pmos, phrog directly boots to the phosh lockscreen when only one user and one session is present. |
Owner
Author
Thanks for testing 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.