-
Notifications
You must be signed in to change notification settings - Fork 6
CI improvements #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CI improvements #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Sam Day <me@samcday.com>
For now they can be manually built via workflow_dispatch. Later, some workflow glue will be wired up to allow this build to be requested via PR comments. Signed-off-by: Sam Day <me@samcday.com>
This should be a little more robust, as well as making more conceptual sense. Creation of a release tag triggers the release build, which does a bit of prep and then creates the release. The workflows that build artifacts for this release trigger off that. Because the release is created by GHA, a custom PAT is needed, otherwise the release event won't trigger the downstream jobs. Zzzz. Signed-off-by: Sam Day <me@samcday.com>
The two APKBUILDs drifted apart a bit. Now the only differences are: * version is suffixed with _git * an upstream-only _gitrev variable is used to track which commit to package (defaults to main for easy local builds) * no shasums (those are computed during workflows) Signed-off-by: Sam Day <me@samcday.com>
This comment has been minimized.
This comment has been minimized.
The prerelease patching isn't much different to before, except _commit is _gitrev now as I was worried that _commit might show up as a string elsewhere in the APKBUILD someday. Introduce patching for release builds. In this case the _git suffix is dropped from pkgrel, and the _gitrev variable is dropped and usages are rewritten to pkgver. The resulting APKBUILD should basically be ready to send downstream to aports exactly as-is, and that's why it's saved as an artifact. Signed-off-by: Sam Day <me@samcday.com>
This was gonna blow up the next release build, I think. Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com> o# Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





No description provided.