Moar packaging #95
Merged
Moar packaging #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prioritize a phoc.ini found in phrog's config dirs, falling back to searching the same locations phosh-session does otherwise. Signed-off-by: Sam Day <me@samcday.com>
Owner
Author
|
/packit build |
This comment has been minimized.
This comment has been minimized.
greetd swallows the output of the greeters it spawns. This is quite suboptimal when spawning a complicated graphical greeter session like phrog, where approximately a trillion different things could go wrong. So we do our best to punt stdout/stderr somewhere useful. For now the heuristic is simple: if we're running under systemd we send the logs to journald, otherwise we assume there's a syslogd somewhere and use logger. Pushing this work into the session script makes it a little more complicated, but it avoids the extra hand-holding in the greetd config.toml. This also benefits pmOS as the upstream Alpine package can be used and it will work correctly across both the OpenRC and systemd variants. Signed-off-by: Sam Day <me@samcday.com>
Alpine OpenRC environment doesn't spin up a dbus-daemon by default. We need to do it ourselves or else phoc hangs in its initialization. Signed-off-by: Sam Day <me@samcday.com>
samcday
force-pushed
the
moar-packaging
branch
from
f32cc64 to
7ba8468
Compare
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
keypad-shuffle
simple-flow
trivial-flow
|
Owner
Author
|
I'm really hoping the fancy process substition redirections don't come back to bite me in the ass. I tested this across my Fedora laptop, a Fedora msm8916 phone and a pmOS (OpenRC) msm8916 tablet. Merging now and booting a 0.44.1 out the door. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94 and #93