[Feature]: Notification lighting only when phone is locked

[romainrichard]

Problem Statement

I've been trying out different configs for edge lighting. Currently I have the "Ambient display" option on because I want to quickly see what the notification is, and the "Show lock screen" off for reasons explained below.

But the "only show when screen off" option isn't just quite what I'd want (note that I've only done the testing using calendar reminders, I assume other notifications behave the same but haven't checked):

State	Only show when screen off enabled	Only show when screen off disabled
Phone locked	Screen wakes up, no edge lighting	Alternates between screen on and edge lighting with screen off
Phone unlocked	No edge lighting	Edge lighting

I like having the option enabled when the phone is unlocked. I don't need the edge lighting because I'm seeing the actual notification already. But I like having the option disabled when the phone is locked. Having the screen alternate between being on and edge lighting makes the notification much harder to miss (which is why I'm not enabling the "Show lock screen" option because otherwise the screen stays on). Ideally I'd like the edge lighting to only be enabled on the lockscreen.

Also, I know this is off-topic (I can create a separate ticket if needed) but kinda related, right now the screen wakes up when a notification is received and turns itself off after 10s. Which means that when the phone is locked, I'm only seeing the edge lighting for 10s, even if I set the pulse count and duration in a way that it would last longer than 10s total. If there's a way to keep the screen awake until the edge lighting is done that would be perfect.

Proposed Solution

Add another toggle for "Only show when phone is locked".

Alternatives Considered

No response

Priority

Medium - Would improve my experience

Contribution

• I would be willing to implement this feature

Additional Context

No response

[sameerasw]

Hi! There's a little issue here... The only show when screen is off option is actually intended for AOD. Since - the screen is on means you are pretty much looking at it now matter locked or not, what this does is that it draws the animated overlay above the AOD to act like those effects found in custom ROMs.

And about keeping the edge lighting always on, there's another couple of issues too.. usually after 10-15 secs on AOD after a notification, the devices goes to low Hz power saving mode. But if we keep it animating, it may either show what's happening once every few seconds which looks bad or worse, it might keep the device at max Hz as accessibility overlay often causes that.

And we can not keep it always visible due to potential OLED burn-in.

So there was a lot of consideration before I picked this specific option. But I will look into a more subtle way if possible and especially if I can get around that Max Hz issue.

[romainrichard]

Well I wasn't expecting that level of complexity haha. Thanks for the details. Since it's not trivial I wouldn't worry too much about it. I've been looking at other apps to add light notifications, maybe I'll find something that does what I need.