Conversation
Some content from Methods will be present in the Methodology section of the paper; this is probably OK?
I thought this might affect the blind paper, but since the URL doesn't actually appear in the paper, it didn't It won't hurt to have an updated version of it in the repo though
Recompiled some graphs, but probably OK since there was no change to their tex files
Ensure that 'usual' glossary output isn't overwritten by 'example' glossaries
Improve how graphs/legends are 'found' by Makefile
*Actually* fix Makefile code for finding graphs/legends Improve how graphs without legends are made
Elaborate on how discrepancies were found Organize example glossaries
More graph formating improvements
Compile paper PDF, since that hadn't been done in a while for these changes
Minor improvements to formatting, including discrep tab ref func name
Add stub for Augmented Discrep Analysis
To be expanded upon in later work
Update commit in link to source code; will need to be updated from this as well
Whoops hehe
Now that I'm more sure it's implemented consistently
Use this example to explain what is meant by 'double counting' and how it is avoided
Confirm that this works as expected by improving existing manual discreps
Bug found by accident when testing how 'implied by' affects counts
Clarify double counting, especially wrt fig:discrepSources
Reduce number of debug print statements to reduce future confusion
Minor improvements to section
|
@samm82 to make it completely unambiguous, can you please include a link to the pdf file that includes the section you want reviewed? Also, please provide the section number. |
|
Feedback:
I like what you are doing @samm82, but I don't think I entirely understand Chapter 4. I think part of the problem is reading it out of context. I don't know what you are planning on already telling the reader by the time they get to this chapter. I also think a formal model of your graph would really help the reader, and likely the author. Maybe @JacquesCarette will have some good ideas on how to be more formal? We can discuss in our meeting later today. |
|
Based on the workflow discussion in #92, I'm merging this PR, with the relevant content to be reviewed later |
Section 4 of my thesis (with some parts being reused in Section III.D of my paper) consists of discussion on how analysis is performed from the perspectives of both what categorizations are used (so far, just explaining "rigidity") and how analysis is automated/augmented with automated tools, which I based off of #82. I think I did a pretty good job of explaining the underlying ideas without getting bogged down by too many details, but a review from the perspectives of people who haven't written the code will put this to the test. Some notes on what is still left to do in this section as part of larger changes:
This also addresses the second to-do item (plus its child items) of #69, although maybe not entirely.