Skip to content

Conversation

@pcriadoperez
Copy link
Collaborator

@pcriadoperez pcriadoperez commented Dec 27, 2025

FIX #1608

Issue 1 - Reconnect on ConnectionClosedOk:

  • Trigger reconnect when receiving Websocket exception ConnectionClosedOk (binance sometimes returns code = 1000)

Issue 2 - user socket and ws-api socket issues:

  1. Shared connection and duplicated read loop - user_socket and ws_api read from the same queue and both had read loops, could cause potential issues
  2. Stale references - if ws_api reconnected, user_socket still held references to the old websocket

To fix issue2 implemented subscription queues so that the ws-api reads from the queues

@pcriadoperez pcriadoperez marked this pull request as draft December 27, 2025 20:37
@pcriadoperez pcriadoperez marked this pull request as ready for review December 31, 2025 01:28
@carlosmiei carlosmiei merged commit 6e4364d into sammchardy:master Jan 2, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'received 1001 (going away); then sent 1001 (going away)'

2 participants