Skip to content

Add Ovis to the CCP modules in the bridgehead#375

Open
tm16-medma wants to merge 30 commits intodevelopfrom
ovis
Open

Add Ovis to the CCP modules in the bridgehead#375
tm16-medma wants to merge 30 commits intodevelopfrom
ovis

Conversation

@tm16-medma
Copy link

No description provided.

Threated and others added 13 commits February 12, 2025 10:45
Please ignore the command in mongo :) It will be replaced soon with proper user authentication
…on to sh

- Removed the traefik service and renamed traefik-forward-auth to ovis- with ovis-traefik-forward-auth the labels, however would need help there as i got no knowledge of how OAuth2 works (Torben initialized that container)
- Updated MongoDB service configuration to include a direct initialization script for user and operation collections in the sh instead of in the compose directly
- Adjusted volume paths to only use the /var/cache/bridgehead/ccp directory
- Adjusted frontend and backend service labels for Traefik routing to not use ports
- Cleaned up unnecessary network definitions and volumes.
- Renamed FHIR Server URL to bridgehead-ccp-blaze:8080/fhir
- Removed redundant entrypoint (python main.py) of fhir transformer
- Replaced GUI_HOST with HOST
- Removed NODE_ENV
- Combine init_onco and backend service
- removed node_modules and .svelte-kit volumes
- removed mongodb volumes
- adjusted http_proxy and https_proxy
- adjusted path prefix from oaut2 to oauth2-ovis
- removed network-mode "host" in fhir-transformer service
@tm16-medma tm16-medma requested a review from a team as a code owner March 19, 2026 13:44
Comment on lines +7 to +8
mkdir -p "/var/cache/bridgehead/ccp/ovis/mongo/init"
mkdir -p "/var/cache/bridgehead/ccp/ovis/shared_data"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if they are auto-created by docker runtime

@tm16-medma
Copy link
Author

Thanks for the comments and your time, we will adjust most of them, others need changes in the application itself for that to work, which takes a bit longer.

tm16-medma added a commit that referenced this pull request Mar 23, 2026
…tracts

Apply the PR #375 review feedback by removing Bridgehead-specific compose/setup overrides
that duplicated upstream OVIS behavior and by switching to the upstream-built Mongo image
that already contains init logic.
- rename CCP OVIS services to consistent upstream-style names (`ovis-*`) and update internal dependencies
- switch Mongo service image from direct `mongo:latest` + host-mounted init script to `docker.verbis.dkfz.de/ovis/ovis-backend-mongodb:latest`
- remove obsolete Mongo init bind mount (`/docker-entrypoint-initdb.d/init.js`) from compose
- drop redundant runtime overrides from compose (`restart`, `command`, `user`, `working_dir`)
- remove duplicated app-default/preprocessor env overrides (`OVIS_PREPROC_*`, misc backend defaults) and keep deployment wiring only
- fix Mongo connection env usage to `ADDRESS` and point services to `ovis-backend-database-mongodb`
- remove temporary root-compat Traefik redirect shim and keep mounted `/ccp-ovis` routing labels
- remove setup-time generation of Mongo init.js and related cache directory prep from `ccp/modules/ovis-setup.sh`
tm16-medma and others added 2 commits March 23, 2026 11:34
…tracts

Apply the PR #375 review feedback by removing Bridgehead-specific compose/setup overrides
that duplicated upstream OVIS behavior and by switching to the upstream-built Mongo image
that already contains init logic.
- rename CCP OVIS services to consistent upstream-style names (`ovis-*`) and update internal dependencies
- switch Mongo service image from direct `mongo:latest` + host-mounted init script to `docker.verbis.dkfz.de/ovis/ovis-backend-mongodb:latest`
- remove obsolete Mongo init bind mount (`/docker-entrypoint-initdb.d/init.js`) from compose
- drop redundant runtime overrides from compose (`restart`, `command`, `user`, `working_dir`)
- remove duplicated app-default/preprocessor env overrides (`OVIS_PREPROC_*`, misc backend defaults) and keep deployment wiring only
- fix Mongo connection env usage to `ADDRESS` and point services to `ovis-backend-database-mongodb`
- remove temporary root-compat Traefik redirect shim and keep mounted `/ccp-ovis` routing labels
- remove setup-time generation of Mongo init.js and related cache directory prep from `ccp/modules/ovis-setup.sh`
Comment on lines +76 to +90
environment:
# CCP mode: FHIR source configuration (ignored by DEMO image)
FHIR_SERVER_URL: http://bridgehead-ccp-blaze:8080/fhir
FHIR_USERNAME: ""
FHIR_PASSWORD: ""
ICD10_FILTER: ""
# Required for both CCP and DEMO: preprocessor upload endpoint
OVIS_PREPROCESSOR_URL: http://ovis-backend-data-preprocessing:9000/omock
# Proxy configuration
HTTP_PROXY: ""
HTTPS_PROXY: ""
NO_PROXY: ""
http_proxy: ""
https_proxy: ""
no_proxy: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remains relevant

Removed proxy configuration from ovis-compose.yml.
Removed unused FHIR configuration variables from ovis-compose.yml.
Collapse the `/ccp-ovis` slash-redirect and prefix-strip flow into one `ovis-frontend-ccp` router by attaching both middlewares in order (redirect, then strip). This removes redundant router labels while preserving canonical `/ccp-ovis -> /ccp-ovis/` behavior and mounted-path forwarding to the frontend service.
Changed the image for the ovis-frontend service to use the new `ovis-frontend-ccp` tag, reflecting the latest version. Removed unnecessary environment variables to streamline the configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants