Add Ovis to the CCP modules in the bridgehead#375
Open
tm16-medma wants to merge 30 commits intodevelopfrom
Open
Add Ovis to the CCP modules in the bridgehead#375tm16-medma wants to merge 30 commits intodevelopfrom
tm16-medma wants to merge 30 commits intodevelopfrom
Conversation
Please ignore the command in mongo :) It will be replaced soon with proper user authentication
…on to sh - Removed the traefik service and renamed traefik-forward-auth to ovis- with ovis-traefik-forward-auth the labels, however would need help there as i got no knowledge of how OAuth2 works (Torben initialized that container) - Updated MongoDB service configuration to include a direct initialization script for user and operation collections in the sh instead of in the compose directly - Adjusted volume paths to only use the /var/cache/bridgehead/ccp directory - Adjusted frontend and backend service labels for Traefik routing to not use ports - Cleaned up unnecessary network definitions and volumes. - Renamed FHIR Server URL to bridgehead-ccp-blaze:8080/fhir - Removed redundant entrypoint (python main.py) of fhir transformer
- Replaced GUI_HOST with HOST - Removed NODE_ENV - Combine init_onco and backend service - removed node_modules and .svelte-kit volumes - removed mongodb volumes - adjusted http_proxy and https_proxy - adjusted path prefix from oaut2 to oauth2-ovis - removed network-mode "host" in fhir-transformer service
Update ovis-compose.yml
lablans
requested changes
Mar 19, 2026
ccp/modules/ovis-setup.sh
Outdated
Comment on lines
+7
to
+8
| mkdir -p "/var/cache/bridgehead/ccp/ovis/mongo/init" | ||
| mkdir -p "/var/cache/bridgehead/ccp/ovis/shared_data" |
Member
There was a problem hiding this comment.
Check if they are auto-created by docker runtime
Threated
reviewed
Mar 19, 2026
Author
|
Thanks for the comments and your time, we will adjust most of them, others need changes in the application itself for that to work, which takes a bit longer. |
TKussel
reviewed
Mar 19, 2026
tm16-medma
added a commit
that referenced
this pull request
Mar 23, 2026
…tracts Apply the PR #375 review feedback by removing Bridgehead-specific compose/setup overrides that duplicated upstream OVIS behavior and by switching to the upstream-built Mongo image that already contains init logic. - rename CCP OVIS services to consistent upstream-style names (`ovis-*`) and update internal dependencies - switch Mongo service image from direct `mongo:latest` + host-mounted init script to `docker.verbis.dkfz.de/ovis/ovis-backend-mongodb:latest` - remove obsolete Mongo init bind mount (`/docker-entrypoint-initdb.d/init.js`) from compose - drop redundant runtime overrides from compose (`restart`, `command`, `user`, `working_dir`) - remove duplicated app-default/preprocessor env overrides (`OVIS_PREPROC_*`, misc backend defaults) and keep deployment wiring only - fix Mongo connection env usage to `ADDRESS` and point services to `ovis-backend-database-mongodb` - remove temporary root-compat Traefik redirect shim and keep mounted `/ccp-ovis` routing labels - remove setup-time generation of Mongo init.js and related cache directory prep from `ccp/modules/ovis-setup.sh`
Removed unnecessary Traefik router configurations for compatibility.
Updated FHIR credentials to empty strings in ovis-compose.yml
Removed dependency condition on the blaze service.
…tracts Apply the PR #375 review feedback by removing Bridgehead-specific compose/setup overrides that duplicated upstream OVIS behavior and by switching to the upstream-built Mongo image that already contains init logic. - rename CCP OVIS services to consistent upstream-style names (`ovis-*`) and update internal dependencies - switch Mongo service image from direct `mongo:latest` + host-mounted init script to `docker.verbis.dkfz.de/ovis/ovis-backend-mongodb:latest` - remove obsolete Mongo init bind mount (`/docker-entrypoint-initdb.d/init.js`) from compose - drop redundant runtime overrides from compose (`restart`, `command`, `user`, `working_dir`) - remove duplicated app-default/preprocessor env overrides (`OVIS_PREPROC_*`, misc backend defaults) and keep deployment wiring only - fix Mongo connection env usage to `ADDRESS` and point services to `ovis-backend-database-mongodb` - remove temporary root-compat Traefik redirect shim and keep mounted `/ccp-ovis` routing labels - remove setup-time generation of Mongo init.js and related cache directory prep from `ccp/modules/ovis-setup.sh`
TKussel
requested changes
Mar 23, 2026
ccp/modules/ovis-compose.yml
Outdated
Comment on lines
+76
to
+90
| environment: | ||
| # CCP mode: FHIR source configuration (ignored by DEMO image) | ||
| FHIR_SERVER_URL: http://bridgehead-ccp-blaze:8080/fhir | ||
| FHIR_USERNAME: "" | ||
| FHIR_PASSWORD: "" | ||
| ICD10_FILTER: "" | ||
| # Required for both CCP and DEMO: preprocessor upload endpoint | ||
| OVIS_PREPROCESSOR_URL: http://ovis-backend-data-preprocessing:9000/omock | ||
| # Proxy configuration | ||
| HTTP_PROXY: "" | ||
| HTTPS_PROXY: "" | ||
| NO_PROXY: "" | ||
| http_proxy: "" | ||
| https_proxy: "" | ||
| no_proxy: "" |
Removed proxy configuration from ovis-compose.yml.
Removed unused FHIR configuration variables from ovis-compose.yml.
Threated
requested changes
Mar 23, 2026
Collapse the `/ccp-ovis` slash-redirect and prefix-strip flow into one `ovis-frontend-ccp` router by attaching both middlewares in order (redirect, then strip). This removes redundant router labels while preserving canonical `/ccp-ovis -> /ccp-ovis/` behavior and mounted-path forwarding to the frontend service.
patrick-skowronek
requested changes
Mar 23, 2026
Threated
approved these changes
Mar 23, 2026
Changed the image for the ovis-frontend service to use the new `ovis-frontend-ccp` tag, reflecting the latest version. Removed unnecessary environment variables to streamline the configuration.
TKussel
approved these changes
Mar 23, 2026
patrick-skowronek
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.