Minor build infrastructure: introduce $(ALL_CPPFLAGS) and use it #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra level of indirection simplifies making additions to the CPPFLAGS used during compilation without interfering with the user's setting for $CPPFLAGS. Fix related typo in the MSYS/MinGW part of configure.ac.
Member
Author
|
(The CI failure is some unrelated intermittent(?) Cirrus CI container issue.) |
Contributor
After signing in to it, I took the liberty of clicking rerun and it's processing now. I guess all CI systems suck periodically! PS. Thanks for the build updates. |
Member
|
Thanks, now merged. |
whitwham
added a commit
to whitwham/htslib
that referenced
this pull request
Jan 27, 2021
Also converted to using ALL_CPPFLAGS from samtools#1187.
daviesrob
pushed a commit
that referenced
this pull request
Jan 27, 2021
Also converted to using ALL_CPPFLAGS from #1187.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra level of indirection, similar to that used in samtools's Makefile, simplifies making additions to the CPPFLAGS used during compilation (and simplifies ensuring that it's done without interfering with the user's setting for
$CPPFLAGS).e.g. this will let #1170 add
-DHTS_CPPFLAGS=\"$(CPPFLAGS)\"toALL_CPPFLAGSwithout needing anyTMP_CPPFLAGS := $(CPPFLAGS)trickery or questions about:=vs::=.Also fix related typo in the MSYS/MinGW part of configure.ac.