Use a constant printf format string in hts_feature_string() [minor]
#1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor this code to avoid a -Wformat-nonliteral warning.
Member
|
Looks like a good idea, as it will allow us to eliminate an entire class of bug. The only side-effect is it changes the order of items in the feature string - hopefully no-one relies on that. I'll merge this and look at adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor this code to avoid a
-Wformat-nonliteralwarning. Since PR #1406 was applied, this is the only instance of this warning produced by the HTSlib code base.With this false positive corrected, it would be possible to turn
-Wformat=2 -Werroron in a CI build.(For GCC builds only; Clang's equivalent option has false positives as it does not suppress the warning for
va_list-using functions.)