Fix NEWS entry for function affected by realn_check_tag() fix #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR samtools#1406 fixed which arguments were used as printf() format strings in realn_check_tag(), which is a subroutine of sam_prob_realn(). Correct the name of the function affected, and add a note of which HTSlib releases were affected.
Member
|
Gah! Annoying that I got the function name wrong. Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1406 fixed which arguments were used as
printf()format strings inrealn_check_tag(), which is a subroutine ofsam_prob_realn()(only). Correct the name of the function affected, and add a note of which HTSlib releases were affected: the problem was introduced in 5c401f2 and fixed in 7981bc9 (on develop) / 328c3f5 (on master & 1.15.1).(FYI see also pysam-developers/pysam#1107 re effects of designating things “security fixes”. Sadly the second
hts_log()instance fixed was indeed a potential issue.)