Fix error code 0 returned by bcftools after error#1504
Merged
daviesrob merged 2 commits intosamtools:developfrom Sep 5, 2022
Merged
Fix error code 0 returned by bcftools after error#1504daviesrob merged 2 commits intosamtools:developfrom
daviesrob merged 2 commits intosamtools:developfrom
Conversation
Without this, bcftools returns error code 0 even when interrupted by these errors visible in stderr:
- [E::hts_itr_next] Failed to seek to offset 70116896333: Illegal seek
- [E::bgzf_read_block] Failed to read BGZF block data at offset 29255442 expected 12238 bytes; hread returned -1
…valid BGZF header at offset xxx
Author
|
The second commit addresses the same problem for issues such as
Test case: Take a valid vcf.gz file and randomly edit the bytes to make it invalid. |
Member
|
Looks good. Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, bcftools returns error code 0 even when interrupted by these errors visible in stderr:
- [E::hts_itr_next] Failed to seek to offset 70116896333: Illegal seek
- [E::bgzf_read_block] Failed to read BGZF block data at offset 29255442 expected 12238 bytes; hread returned -1
This code change is in line with what is written in the next
elseblock