Fix Point.extents for empty and label-only markers#228
Merged
tshead2 merged 2 commits intosandialabs:mainfrom Mar 19, 2026
Merged
Fix Point.extents for empty and label-only markers#228tshead2 merged 2 commits intosandialabs:mainfrom
tshead2 merged 2 commits intosandialabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a scatterplot regression introduced by the recent point extent changes.
Point.extents()was assuming that every marker had a truthyshapeand could be handled as a shape-based marker. That breaks when cartesian finalize requests point extents for clipping and the scatterplot
contains markers like
None,"", or label-only markers. In that case the extent code ends up indexingshape[0]and crashes.Fix
This change makes
Point.extents()match actual marker rendering behavior more closely:Noneor""The label extent styling also now mirrors the defaults already used by the HTML marker renderer, so extent
calculation matches rendered output.
Reproducer
This was reported with: