Add ReportLab cubic path support#230
Merged
tshead2 merged 1 commit intosandialabs:mainfrom Mar 19, 2026
Merged
Conversation
Member
|
Looks like a winner, many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tshead2, this is a simple feature addition I would love to have supported.
Summary
Ccommands and close-pathZ/zDetails
Toyplot's ReportLab backend already handled simple SVG path commands, but it did not translate cubic Bezier
segments. This PR adds support for cubic path rendering so SVG paths that include
Ccommands can be convertedinto the corresponding ReportLab
curveTo()calls.The change also covers path closing, and adds a focused regression test that checks the backend issues the
expected
beginPath(),moveTo(),lineTo(),curveTo(),close(), anddrawPath()calls.Testing
python -m behave features/reportlab.feature --logging-level INFO --no-logcaptureNotes
Example
Its useful for creating some cool plots like this and ensuring they can render to PDF.