Fix for Rails 8.1 - updating the Resource instantiation with the latest API changes#10
Merged
dasunpubudumal merged 16 commits intomasterfrom Jan 26, 2026
Merged
Fix for Rails 8.1 - updating the Resource instantiation with the latest API changes#10dasunpubudumal merged 16 commits intomasterfrom
Resource instantiation with the latest API changes#10dasunpubudumal merged 16 commits intomasterfrom
Conversation
Resource instantiation with the latest API changes
harrietc52
approved these changes
Jan 26, 2026
|
Can’t help but think, as a new “Process Improvement”, that this bug will get us in other apps, it it would be nice to have a almost list/ table of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded to fit Rails 8.1.
Inside the
jsonapi_resourcesblock, there's a call to aResourceclass (which translates into a Railsresource) that Rails 8.1 doesn't like. Its API has been updated to accept only 3 arguments whereas we give 4 injsonapi-resources(due to a destructured hash).This will be used in Traction Rails 8.1.