Skip to content
This repository was archived by the owner on Dec 14, 2025. It is now read-only.

Conversation

@vslinko
Copy link

@vslinko vslinko commented May 20, 2016

No description provided.

@sanniassin
Copy link
Owner

@vslinko It would be nice to have a description of this PR and it's benefits.

@vslinko
Copy link
Author

vslinko commented May 21, 2016

You could see conversation on this PR insin/react-maskedinput#52

@sanniassin
Copy link
Owner

@vslinko Won't merge. While i can understand benefits it's not a good architectural decision to simulate DOM element because it's not and it may confuse if you can focus but can't get value or set selection. So i recommend to use findDOMNode on react-input-mask component and interact with real HTMLInputElement.

@vslinko
Copy link
Author

vslinko commented May 21, 2016

It seems like you're right. I just forgot that I can use findDOMNode on the composite component. Closing the PR.

@vslinko vslinko closed this May 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants