Create and reconcile ServerNetworkConfig alongside BMC#145
Open
Create and reconcile ServerNetworkConfig alongside BMC#145
Conversation
metal-operator now gates the Discovery→Available transition on the presence of a ServerNetworkConfig object per server. This change makes argora responsible for creating that object when a BMC is first provisioned and keeping its spec.interfaces up-to-date on every subsequent reconcile. Changes: - Add go.mod replace directive pointing at the local metal-operator fork that contains the new ServerNetworkConfig type (upstream version TBD) - Add Namespace field to IronCoreReconciler with a corresponding --ironcore-namespace CLI flag; ServerNetworkConfig is namespace-scoped unlike BMC/BMCSecret which are cluster-scoped - Add RBAC marker for servernetworkconfigs (get/list/watch/create/update/patch) - Add buildExpectedInterfaces: queries NetBox DCIM for the device's interfaces and filters out LAG, mgmt-only, and unconnected entries - Add createServerNetworkConfig: called once after a new BMC is created - Add updateServerNetworkConfig: called on every reconcile when the BMC already exists, patches spec.interfaces and labels to reflect the current NetBox state; falls back to create if the object is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metal-operator now gates the Discovery→Available transition on the presence of a ServerNetworkConfig object per server. This change makes argora responsible for creating that object when a BMC is first provisioned and keeping its spec.interfaces up-to-date on every subsequent reconcile.
Changes:
Important