Catch a couple uncaught exceptions#22
Merged
bbobrov merged 2 commits intostable/zed-m3from Nov 23, 2023
Merged
Conversation
Change-Id: Iccc7015ae715dea29f76d9be09d21c850aaa9b7e
The operation of getting the user and setting last_active_at is not atomary. There might be situations where the user does not exist already, an uncaught exception is getting raised. Check that the user ref is not empty before modifying it. Change-Id: Idf96a3670cc842128c8515a398e4447227496f28
bbobrov
changed the title
bbobrov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 changes to catch uncaught exceptions