Rework concourse_unit_test_task#41
Merged
stanislav-zaprudskiy merged 12 commits into2025.1-cherry-picksfrom Nov 27, 2025
Merged
Rework concourse_unit_test_task#41stanislav-zaprudskiy merged 12 commits into2025.1-cherry-picksfrom
concourse_unit_test_task#41stanislav-zaprudskiy merged 12 commits into2025.1-cherry-picksfrom
Conversation
It doesn't cause failures without the argument.
Concourse already has the repo version to be tested cloned under `source` path.
Executing without memcached doesn't change the number of tests and the outcome.
It looks like runtime parameter, not changing tests behavior.
It doesn't have to be one-line, given the way Concourse runs it. But working with it as with a regular script is much easier in development and testing.
Installing them on Ubunbut 24.04 fails - https://stackoverflow.com/a/75696359. Whereas an alternative option could be to use `--break-system-packages` - which is less nicer than venv IMHO.
Upstream tests run with v4+, and our could too.
The OS requirements packages change over time (some of which are no longer relevant for e.g. Ubuntu 24.04), and are maintained in `bindep.txt`. So just install them with `bindep`, similar to how Zuul does that upstream - https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/bindep/tasks/packages.yaml. The disadvantage could be that it could install more than required - e.g. mysql, postgresql or graphviz, which we don't need for our test run.
Without `safe.directory` it fails to use `git` under `/source`, and fails to recognize pbr version correspondingly (https://docs.openstack.org/pbr/latest/user/features.html#version).
With or without them the number of executed tests and the outcome are the same. Not sure why so - needs more investigation. But just maintain them as in the documentation - https://docs.openstack.org/keystone/latest/contributor/testing-keystone.html#ldap-tests
This is to make sure that it won't succeed in case the interpreter could not be found.
stanislav-zaprudskiy
changed the title
concourse_unit_test_task
stanislav-zaprudskiy
merged commit 7f2f18c
into
2025.1-cherry-picks
0 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #38
The primary motivation was 072411c. And the rest was just revisiting and tidying up of the legacy.
Concourse executes it similar to the command below, which was also used for testing of this PR:
which returns the following at the end