Skip to content

Conversation

@groenroos
Copy link
Member

Implements the limit, skip and sort options in the Memory driver.

Closes #163

@groenroos groenroos added the feature Brand new features to Sapling label Feb 25, 2022
@groenroos groenroos added this to the M2 - Release 2.0 milestone Feb 25, 2022
@groenroos groenroos self-assigned this Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #421 (b5bac20) into master (e4c28f5) will decrease coverage by 0.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
- Coverage   98.05%   98.02%   -0.03%     
==========================================
  Files          37       37              
  Lines        4575     4607      +32     
==========================================
+ Hits         4486     4516      +30     
- Misses         89       91       +2     
Impacted Files Coverage Δ
drivers/db/Memory.js 98.41% <93.93%> (-0.68%) ⬇️
lib/Storage.js 89.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c28f5...b5bac20. Read the comment docs.

@groenroos groenroos merged commit e30645f into master Feb 25, 2022
@groenroos groenroos deleted the feature/memory-options branch February 25, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Brand new features to Sapling

Development

Successfully merging this pull request may close these issues.

Implement read options in Memory driver

2 participants