Skip to content

Conversation

@imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Nov 27, 2022

I broke jump to definition of ObjectValidator when adding undefinedToOptional

ref: microsoft/TypeScript#47813
there's a pr to fix it too: microsoft/TypeScript#51650

@codecov-commenter
Copy link

Codecov Report

Base: 99.34% // Head: 99.35% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (21084ed) compared to base (09e9a4d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   99.34%   99.35%           
=======================================
  Files          57       57           
  Lines        3382     3397   +15     
  Branches      811      811           
=======================================
+ Hits         3360     3375   +15     
  Misses         13       13           
  Partials        9        9           
Impacted Files Coverage Δ
src/lib/util-types.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@favna favna changed the title build: just to definition fix: fixing "jump to definition" for undefinedToOptional Nov 27, 2022
@favna favna changed the title fix: fixing "jump to definition" for undefinedToOptional fix: fixed "jump to definition" for undefinedToOptional going to wrong symbol Nov 27, 2022
@favna favna merged commit 6aab6d0 into sapphiredev:main Nov 27, 2022
@imranbarbhuiya imranbarbhuiya deleted the types/just-to-defination branch November 28, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants