Update Christian.ics to correct dates for Ash Wednesday - did not take leap years into account.#2
Open
Scoundrel42 wants to merge 1 commit into
Open
Update Christian.ics to correct dates for Ash Wednesday - did not take leap years into account.#2Scoundrel42 wants to merge 1 commit into
Scoundrel42 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a RRULE has a BYMONTH earlier than March, leap years and non-leap years must be handled separately. Do this by creating four 76-year rules instead of one 19-year rule; each 76-year rule contains all leap years or all non-leap years.
This works for 1901-2099, but not for 1900 and 2100. So the Ash Wednesday VEVENTs only cover that range.