Ada: better error messages

[onnozweers]

Now, when a user is not authorized, Ada often returns "Could not determine object type". This is not a very helpful message. We need to catch the real error the API returns to Curl, and make that visible to the user.

[onnozweers]

It's mainly this piece of code.

pathtype () {
  # Get the type of an object. Possible outcomes:
  # DIR     = directory
  # REGULAR = file
  # LINK    = symbolic link
  # <empty> = something went wrong... no permission?
  local path
  path=$(urlencode "$1")
  curl "${curl_authorization[@]}" \
       "${curl_options_no_errors[@]}" \
       -X GET "$api/namespace/$path" \
  | jq -r .fileType
}

SpiderScripts/ada/ada

Line 685 in 2a4a032

pathtype () {

The HTTP code returned by curl is not caught. We need to catch it, and if there is an error (code not in range 200-399, or unexpected output): print it and exit with an exit code not 0.

[onnozweers]

When curl is invoked without --fail, it returns a JSON with a proper error message:

{
  "detail": "Forbidden",
  "title": "Forbidden",
  "status": "403"
}

Then, with echo "$result" | jq 'has("fileType")', you can test whether you have a normal result ('true') or an error ('false').