Skip to content

Conversation

@sabhas
Copy link
Member

@sabhas sabhas commented Feb 21, 2023

Intent

  • csv-stringify was a bit problematic in sasjs/cli. So, replaced it with fast-csv/format

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
  • All sasjs-cli unit tests are passing (npm test).
  • Reviewer is assigned.

@sasjsbot sasjsbot requested a review from medjedovicm February 21, 2023 20:51
@allanbowe allanbowe merged commit 6f818da into main Feb 21, 2023
@allanbowe allanbowe deleted the replace-csv-stringify branch February 21, 2023 21:43
@sasjsbot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants